- Notifications
You must be signed in to change notification settings - Fork13.3k
Help newlib TZ parser#7699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Timezones coded with <±nn>±nn<±nn>[±nn][,...] are incorrectly parsed by newlib's TZ parser.In these timezones, <±nn> is used because there is no matching name like in other timezones.Example: 'GMT0BST' for London, (GMT is known, BST is 'British Summer Time').Example: '<+1030>-10:30<+11>-11' for Lord Howe Island.These names GMT,BST,CET,... are meant to be human readable but are useless in our use case.Replacing <±nn> occurences by UNK allows newlib's TZ parser to nicely interpret all timezones.Ultimately, newlib should handle such tz descriptor. Until then, they are handled by this script.
6 tasks
earlephilhower approved these changesNov 10, 2020
Collaborator
earlephilhower commentedNov 10, 2020
Would you like to put in a bug on the newlib repo for this change?https://github.com/earlephilhower/newlib-xtensa |
CollaboratorAuthor
d-a-v commentedNov 10, 2020
earlephilhower added a commit to earlephilhower/Arduino that referenced this pull requestNov 12, 2020
Undoes the change inesp8266#7699 andfixedesp8266#7690 root cause.Newlib did not support timezone names of the form "<[+-]?[0-9]+>" andwould parse the offset using the <name>.Fix newlib tzset parser withearlephilhower/newlib-xtensa#14and undo the UNK changes used as an expedient workaround.
earlephilhower added a commit that referenced this pull requestNov 12, 2020
Undoes the change in#7699 andfixed#7690 root cause.Newlib did not support timezone names of the form "<[+-]?[0-9]+>" andwould parse the offset using the <name>.Fix newlib tzset parser withearlephilhower/newlib-xtensa#14earlephilhower/newlib-xtensa#15and undo the UNK changes used as an expedient workaround.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timezones coded with
<±nn>±nn<±nn>[±nn][,...]are incorrectly parsed by newlib's TZ parser.In these timezones,
<±nn>is used because there is no matching name like in other timezones.Example:
GMT0BSTfor London, (GMT is known, BST isBritish Summer Time).<+1030>-10:30<+11>-11for Lord Howe Island.These names GMT,BST,CET,... are meant to be human readable but are useless in our use case.
Replacing
<±nn>occurences byUNKnown allows newlib's TZ parser to nicely interpret all timezones.UNK-10:30UNK-11is then correctly parsed.Ultimately, newlib should handle such TZ descriptors. Until then, they are handled by this script.
Fixes#7690