- Notifications
You must be signed in to change notification settings - Fork13.3k
Update to ESP8266HTTPClient.cpp for no Content-Length#7691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Response bodies are ignored when _transferEncoding == HTTPC_TE_IDENTITY and there is no Content-Length header. The added code here fixes that issue.
earlephilhower left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Little minor refactor, please.
Uh oh!
There was an error while loading.Please reload this page.
earlephilhower left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the cleanup.
Uh oh!
There was an error while loading.Please reload this page.
d-a-v commentedNov 15, 2020
Now that it's working but with an unwilling timeout, you can update |
drderiv commentedNov 16, 2020
With apologies, I'm not seeing how this would help, at least in the current implementations of Perhaps the word 'meantime' threw me and you are asking for the |
d-a-v commentedNov 16, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
In#6979, But before#6979 is considered, a fix is needed for your issue, and#7692 too which is the same issue. End of TCP connection cannot currently be handled by If this works for you, please update your PR. |
Add logic to writeToStreamDataBlock to only read what's available so as to avoid timeout, and adjust formatting.
drderiv commentedNov 16, 2020
That worked nicely. And now I understand what you meant about effectively checking |
Uh oh!
There was an error while loading.Please reload this page.
Response bodies are ignored when _transferEncoding == HTTPC_TE_IDENTITY and there is no Content-Length header. The added code here attempts to fix that issue by writing the response body based upon how much content is available to be read.
edit:
Fixes#7692