NotificationsYou must be signed in to change notification settings
Fork13.3k
Star16.5k

Fix uninitted class variables from #7464#7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

earlephilhower merged 2 commits intoesp8266:masterfromearlephilhower:initfix

Jul 23, 2020

Merged

Fix uninitted class variables from #7464#7478

earlephilhower merged 2 commits intoesp8266:masterfromearlephilhower:initfix

Jul 23, 2020

Conversation

Copy link

Collaborator

earlephilhower commentedJul 23, 2020

PR#7464 removed the reset of client authentication settings when server
authentication settings were changed, however it never did initialize
the client authentication information to nullptr in the constructor.
This can result in crashes during connections when client certs are not
applied.

Fix by resetting the client authenticaion variables on object
construction.

Fix uninitted class variables fromesp8266#7464

ed74feb

PResp8266#7464 removed the reset of client authentication settings when serverauthentication settings were changed, however it never did initializethe client authentication information to nullptr in the constructor.This can result in crashes during connections when client certs are notapplied.Fix by resetting the client authenticaion variables on objectconstruction.