- Notifications
You must be signed in to change notification settings - Fork13.3k
mDNS: protect MDNSResponder::queryService against misuse#7216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| constchar* p_pcProtocol, | ||
| constuint16_t p_u16Timeout/*= MDNS_QUERYSERVICES_WAIT_TIME*/) | ||
| { | ||
| if (0 == m_pUDPContext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't this a ptr? check against nullptr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes. For coherency I sticked to this file's style.
| if (0 == m_pUDPContext) |
I was afraid to modify too much for when LEAmDNS2 is coming to avoid merge complication.
fixes#7215