- Notifications
You must be signed in to change notification settings - Fork13.3k
Ability to define -DFP_IN_IROM when generating ld script#7188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
earlephilhower left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but unfortunately I'm not a PIO user so can't comment if this is the best way to get another flag in.
| join(FRAMEWORK_DIR,"tools","sdk","ld","eagle.app.v6.common.ld.h"), | ||
| env.VerboseAction( | ||
| "$CC -CC -E -P -D%s $SOURCE -o $TARGET"%current_vtables, | ||
| "$CC -CC -E -P -D%s%s$SOURCE -o $TARGET"%(current_vtables,fp_in_irom), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't speak pythonese or use platformio; however, shouldn't there be a -D in front of the new '%s'.
Déjà Vu, I changed the same line in a PoC PR
Arduino/tools/platformio-build.py
Line 274 in91fc391
| "$CC -CC -E -P -D%s -D%s $SOURCE -o $TARGET"% (current_vtables,current_mmu_iram_size), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, because the second parameter can be absent. This would result in-D being inserted and potentially causing an error.
The-D is already included above here:fp_in_irom = "-DFP_IN_IROM"
Follow up of#7180, there was no way to enable the
-DFP_IN_IROMflag when generating the ld script.