NotificationsYou must be signed in to change notification settings
Fork13.3k
Star16.5k

Tone limit 20KHz#7179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

earlephilhower merged 7 commits intoesp8266:masterfromTech-TX:tone_limit_comments

Apr 4, 2020

Merged

Tone limit 20KHz#7179

earlephilhower merged 7 commits intoesp8266:masterfromTech-TX:tone_limit_comments

Apr 4, 2020

Conversation

Copy link

Contributor

Tech-TX commentedApr 1, 2020

Add 2 comments since I found out where the 5KHz upper limit on Tone output frequency was, apparently added for compatibility with the Arduino library some time in the past.

If you want the full 20KHz audio frequency range, change the two lines in Tone.cpp at line 38 to:

  high = std::max(high, (uint32_t)25);// new 20KHz maximum Tone frequency  low = std::max(low, (uint32_t)25);

Tech-TX added2 commits

March 31, 2020 20:23

add comments for tone max frequency limit

f5000ad

add comments for tone max frequency limit

a5eb7ea

earlephilhower requested changes

Apr 1, 2020

View reviewed changes

Copy link

Collaborator

earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the add'l comment, but I can see no reason not to extend the range by default to 20kHz like you were mentioning.

cores/esp8266/Tone.cpp OutdatedShow resolvedHide resolved

set Tone maximum frequency to 20KHz (was 5KHz)

30df0ae

Copy link

ContributorAuthor

Tech-TX commentedApr 1, 2020

Done, and done! I'll good with removing artificial restraints on operation. 😄
Travis CI running now.

Copy link

ContributorAuthor

FYI, I've already tested this change yesterday much farther than 20KHz. When I tried to take it to 65535 it blew up, but I sort of expected that based on your notes elsewhere about CPU utilization at 40KHz PWM.