NotificationsYou must be signed in to change notification settings
Fork13.3k
Star16.5k

simple TZ api: bypass sprintf/sscanf: + 7KB#7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

d-a-v merged 2 commits intoesp8266:masterfromd-a-v:overwealtz

Feb 25, 2020

Merged

simple TZ api: bypass sprintf/sscanf: + 7KB#7109

d-a-v merged 2 commits intoesp8266:masterfromd-a-v:overwealtz

Feb 25, 2020

Conversation

Copy link

Collaborator

d-a-v commentedFeb 24, 2020

fixes#7107
@Jason2866 do you confirm tasmota fits in its previous size ?
About that, are you using compressed OTA ?

simple TZ api: bypass sprintf/sscanf: + 7KB

058e476

devyte requested changes

Feb 25, 2020

View reviewed changes

cores/esp8266/time.cpp OutdatedShow resolvedHide resolved

earlephilhower approved these changes

Feb 25, 2020

View reviewed changes

Copy link

Collaborator

earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great way to save code for those left with 512KB flash!, while preserving the use of library code.

Other than the#if comment from@devyte, LGTM.

Copy link

Contributor

Jason2866 commentedFeb 25, 2020•
edited
Loading

@d-a-v Thx!, The PR eliminates the firmware size increase. :-)
Yes, we do use compressed and uncompressed OTA. Both works like a charm!

using obfuscating comments instead of #if 0

b897f74

Copy link

CollaboratorAuthor

I was asking about OTA because I have been thinking that increased size on one side would be compensated by size decrease on the other (thanks to compressed OTA). But as@earlephilhower noted, there are still 512K flash chips around, these ones could use any flash size optimization.