NotificationsYou must be signed in to change notification settings
Fork13.3k
Star16.5k

TCP: fixes backlog limit handling, and allows ephemeral TCP connections#7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

d-a-v merged 4 commits intoesp8266:masterfromd-a-v:FixBacklogHonorEphemeral

Feb 24, 2020

Merged

TCP: fixes backlog limit handling, and allows ephemeral TCP connections#7096

d-a-v merged 4 commits intoesp8266:masterfromd-a-v:FixBacklogHonorEphemeral

Feb 24, 2020

Conversation

Copy link

Collaborator

d-a-v commentedFeb 21, 2020•
edited
Loading

When a sketch does not checkserver::available() often enough, short connections arenow received and stored in background (backlog limit number of connections at most) and can be retrieved and used by subsequentclient = server::available(). Those clients will bestatus() == CLOSED,connected() == false butavailable() > 0.

@kirillandy Could you check this ? I get what's expected by#2569 with these changes.

@JAndrassy This is still not what you are waiting for but it would be nice if you checked nothing has changed on the arduino side (WiFiClient::operator bool() has changed).

fixes#2569

edit:

fixes#7103

d-a-v added2 commits

February 21, 2020 17:31

fix backlog limit handling, and allow ephemeral TCP connections

ac0dd37

do not retain empty connections

ce67c08

Copy link

kirillandy commentedFeb 22, 2020•
edited
Loading

Hi@d-a-v ! Currently trying to check your changes out, but I'm not too certain about my actions.
So I installed the current ESP Arduino library version using Git (as the docs instruct). After a bit of research I then used "git mergehttps://github.com/d-a-v/Arduino.git FixBacklogHonorEphemeral" to apply your changes on what I have locally stored on my PC.

Is that all I need to do before I compile my code to test out on my ESPs?
(Also, if my actions were correct, was there an easier way to do what I did? :D)

Copy link

kirillandy commentedFeb 22, 2020

UPDATE:
So, if everything I did to get hold of your commit was correct (still need some friendly guidance on that, since this is my first time properly using Git and its commands :)), then everything works like a charm! I repeated my previous experiment by sending a few bytes when the server was not available-looping and the server was able to get the client and read the bytes 👍
I also tried sending bytes in 3 different connections one after the other to check if they'd all be in the queue and the server managed to .available() all 3 and read every message.
Thanks a lot for your work,@d-a-v!