Feb 14, 2020 · Mar 5, 2020
diff --git a/libraries/Servo/src/Servo.cpp b/libraries/Servo/src/Servo.cpp
 void Servo::detach()
 {
  if (_attached) {
    pinMode(_pin, INPUT);
    stopWaveform(_pin);
    _attached = false;
    digitalWrite(_pin, LOW);
  }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -82,9 +82,9 @@ uint8_t Servo::attach(int pin, uint16_t minUs, uint16_t maxUs)
		void Servo::detach()
		{
		if (_attached) {
		pinMode(_pin, INPUT);
Copy link Collaborator earlephilhowerMar 5, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. INPUT leaves the pin in a high impedance state and subject to noise unless an external pull-up/down resistor is added to the circuit. INPUT_PULLUP, however, will have a weak pull-to-VCC resistor placed on the pad. Two potential issues are: Is "always 1" a valid, safe state for servo control inputs? What is the "typical" input impedance of a servo, and how does it compare to the (weak, can't seem to find the exact value) internal pullup?
		stopWaveform(_pin);
		_attached = false;
		digitalWrite(_pin, LOW);
		}
		}

Expand Down