Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Pull GPIO initialization into its own 'weak' function.#7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-a-v merged 3 commits intoesp8266:masterfromeverslick:patch-4
Mar 22, 2020
Merged

Pull GPIO initialization into its own 'weak' function.#7044

d-a-v merged 3 commits intoesp8266:masterfromeverslick:patch-4
Mar 22, 2020

Conversation

@everslick
Copy link
Contributor

By pulling GPIO init into its own weak function, it can be overridden by the user. This is important in cases when GPIOs should not toggle during reboot, exceptions or other crashes.Fixes#7041.

By pulling GPIO init into its own weak function, it can be overridden by the user. This is important in cases when GPIOs should not toggle during reboot, exceptions or other crashes.Fixes#7041.
@d-a-vd-a-v added this to the2.7.0 milestoneMar 17, 2020
@d-a-v
Copy link
Collaborator

@everslick
Will you fix this error ?

core_esp8266_wiring_digital.cpp: In function 'void initPins()':core_esp8266_wiring_digital.cpp:254:13: error: 'resetPins' was not declared in this scope   resetPins();             ^

@everslick
Copy link
ContributorAuthor

everslick commentedMar 19, 2020•
edited
Loading

I think it is only the missing prototypevoid resetPins(); in wiring_private.h. I submitted the PR via the github online editor., which only allows me to change ONE file per PR (I think).

Unfortunately I'm not at my workstation for at least 3 days.If it is not a big hassle to you I'd kindly ask you (@d-a-v) to add the line this time.

I just added the missing line to patch-4 and made a new PR. Lets see if the CI build succeeds now....

@everslick
Copy link
ContributorAuthor

Looks good! :-)

d-a-v reacted with thumbs up emoji

@d-a-vd-a-v merged commite64cb61 intoesp8266:masterMar 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@d-a-vd-a-vd-a-v approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

GPIOs get re-init during software restarts

2 participants

@everslick@d-a-v
[8]ページ先頭
©2009-2025 Movatter.jp