- Notifications
You must be signed in to change notification settings - Fork13.3k
WiFi: ARP gratuitous API for wifi station mode#6889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
TD-er commentedDec 7, 2019
Just looking at the code and I think this is probably not optimal to use. boolESP8266WiFiSTAClass::stationKeepAliveEnabled (){return _keepStationAliveUs !=0;}voidESP8266WiFiSTAClass::stationKeepAliveStop (){ _keepStationAliveUs = -1;// will be set to 0 at recurrent call}boolESP8266WiFiSTAClass::stationKeepAliveSetupMs (int ms){if (_keepStationAliveUs !=0 || ms <=0)returnfalse;[...] So on other words, you can only change the value by calling stop and then wait for the next scheduled interval before you can even set a new value. Also I do miss to send (or restart the scheduler) when a wifi connection to the AP is established. |
d-a-v commentedDec 8, 2019
@TD-er please review the API change |
Uh oh!
There was an error while loading.Please reload this page.
d-a-v commentedDec 8, 2019
@TD-er the API has changed, based on your use case. Setting the interval will:
|
Uh oh!
There was an error while loading.Please reload this page.
marrold commentedDec 12, 2019
Novice question, is there a simple way I can test this branch in platformio? |
d-a-v commentedDec 12, 2019
If you are using git for this repository in your platformIO setup, then yes. |
Jason2866 commentedApr 7, 2020
Sorry for replying sooo late. We had no equipment until now to reproduce the issue (of not beeing reachable via http after a while) in our wifi setups. Since a few days i have a OpenWRT AP which has this issue... It would be great if you merge this PR that all users can benefit from this option to solve issues |
s-hadinger commentedApr 7, 2020
I confirm this feature is useful with some wifi routers. I ported this feature in Tasmota, and it would be great for it to be integrated natively in Arduino Core. Some other projects might benefit from it. |
ticker: +commentgratuitous: use attach_ms_scheduled_accurate
d-a-v commentedApr 8, 2020
Per internal review comment:
|
d-a-v commentedApr 8, 2020
@ivankravets@platformio I need help withthis issue: Following change does not help (because in that case arduino does not compile This |
d-a-v commentedApr 9, 2020
Moving |
valeros commentedApr 9, 2020
Hi@d-a-v ! Looks like these changes are going to affect a lot of PlatformIO users since |
s-hadinger commentedApr 9, 2020
What about just leaving the |
d-a-v commentedApr 9, 2020
@valeros good idea but as@s-hadinger says, it may include Ticker for nothing if gratuitous is not used (unless it is moved in a separate directory ?). |
Based on multiple reports and examples
fixes#6886
fixes#5998 (together with#6484, hopefully)