- Notifications
You must be signed in to change notification settings - Fork277
Use binder directory for configuration files#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is now unnecessary, so don't do it.Also remove the instructions that aren't needed now.
matthewfeickert commentedFeb 15, 2020
For reference, the Binder build for this branch on my fork is here:https://mybinder.org/v2/gh/matthewfeickert/bayesian-stats-modelling-tutorial/use-binder-dir-example |
ericmjl commentedFeb 15, 2020
Wonderful stuff,@matthewfeickert! |
ericmjl commentedFeb 15, 2020
I appreciate all the thought you put into the PR,@matthewfeickert. This is how open source is supposed to be done! 😄 |
matthewfeickert commentedFeb 15, 2020
Ah, thank you@ericmjl! That's so kind of you to say. 🙂 The work that you do for the Python community (like this true gem of a tutorial repo) is truly inspirational and I'm more then pleased if I can have helped out in a very small way. |
hugobowne commentedFeb 15, 2020
Echoing sentiments in both directions here :) |
In response to@ericmjl'stweet RE: Binder configuration file conflicts, this PR adopts the use of a
binderdirectory for configuration files which eliminates any conflict asAs placing theConda
environment.ymlconfig file affects the path that both the user focused documentation and the CI use, paths and docs that explicitly use the path to the config file are updated.As this does now require users to think more explicitly about the path to the
environment.ymlat environment creation time I can understand that this might be something that could be a deal breaker for this PR. However, I think that most people should be fine with typing a few more letters and probably don't deeply carewhere their environment config files live.This also reverts the movement of the
Dockerfileand the.dockerignoreas this was just done to avoid the issue, but there is no reason to do this anymore so don't.Finally, the Binder badge used is updated to reflect the modern (as of 2019) Binder badge (with logo).