- Notifications
You must be signed in to change notification settings - Fork35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
runeclipse: Support multiple license servers#718
Conversation
I'd suggest removing the ert bottom pin in pyproject.toml for this PR and we can re-add it in a follow-up PR, after making a new release. I guess there is value in having subscript run against ert pre-release versions in the nightly ci here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks OK to me. I have not tested it. 👍
codecov-commenter commentedJul 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #718 +/- ##======================================= Coverage 85.73% 85.73% ======================================= Files 50 50 Lines 6696 6696 ======================================= Hits 5741 5741 Misses 955 955 ☔ View full report in Codecov by Sentry. |
Close#714