- Notifications
You must be signed in to change notification settings - Fork35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix test_sunsch#700
Fix test_sunsch#700
Conversation
| assert "A-007" in str(sch) | ||
| assert "<ORAT>" in str(sch) | ||
| # (this error is let through sunsch) | ||
| # Let the date be undefined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
opm doesn't accept argument anymore. Previously, it was taken as UDQ, but now it's flagged as invalid UDQ (with the new name validation)
| @@ -776,7 +759,7 @@ def test_weltarg_uda(tmp_path): | |||
| """WELTARG supports UDA from opm-common 2020.10""" | |||
| os.chdir(tmp_path) | |||
| weltargkeyword = """WELTARG | |||
| 'OP-1' ORATSOMEUDA / | |||
| 'OP-1' ORATWU_VALUE / | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ReplaceSOMEUDA withWU_VALUE to meet the valid UDQ name criteria.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks fine!
The latest
opmhas implemented check for valid UDQ based on its name. This create issue withsunschtest.OPM/opm-common#3842
This PR fixes the test that failed due to the changes.