Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Get Property from Node expression block#34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dylanmccall wants to merge6 commits intomain
base:main
Choose a base branch
Loading
fromT35497-object-properties

Conversation

dylanmccall
Copy link
Contributor

@dylanmccalldylanmccall commentedJun 15, 2024
edited
Loading

@dylanmccall
Copy link
ContributorAuthor

I did start to rebase this, but it looks like there's an unrelated issue in main blocking me from testing it (and fixing my examples), so I'll leave this with the conflicts for now. I did realize that aTo String {int: INT} block was added today, so, we'll have to sort that out, but I think having anAs String {value: VARIANT} makes more sense, especially if we can get those variant inputs to accept all the concrete types as well :)

@dylanmccalldylanmccallforce-pushed theT35497-object-properties branch 2 times, most recently from1b1415e to8dfa35cCompareJune 17, 2024 21:04
Copy link
Contributor

@manuqmanuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me. I left a comment for the Variant type and suggestions.

Ideally learners should not have to enter property names or node names by text. I remember plugins opening a node selector. Maybe we should do that for blocks with a node parameter. It seems thatPROPERTY_HINT_NODE_TYPE can be useful. The alternative is to traverse the tree and create blocks like "This object".

@@ -83,6 +83,11 @@ static func get_general_categories() -> Array[BlockCategory]:
b.statement = "print({text})"
test_list.append(b)

b = BLOCKS["statement_block"].instantiate()
b.block_format = "print value {value: VARIANT}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about not passing a type at all when type is not needed? Something like"print value {value}" is assumed to have no type. So this can match#43 better.

Ultimately I think we should get rid ofserialized_props and stop converting back and forth from enum types to strings. And have resources for every block, with parameters as exported properties.

@dylanmccalldylanmccall marked this pull request as draftJune 19, 2024 23:47
@dylanmccalldylanmccall changed the titleAdd Variant type, and Get Property from Node expression blockAdd Get Property from Node expression blockJun 19, 2024
@dylanmccalldylanmccallforce-pushed theT35497-object-properties branch from6c2ef3a to7f9a689CompareJune 19, 2024 23:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@manuqmanuqmanuq approved these changes

@wnbaumwnbaumAwaiting requested review from wnbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dylanmccall@manuq

[8]ページ先頭

©2009-2025 Movatter.jp