Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix cursor pagination ordering#9816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ulgens wants to merge4 commits intoencode:main
base:main
Choose a base branch
Loading
fromulgens:fix-cursor-pagination-ordering

Conversation

@ulgens
Copy link
Contributor

Resolves#9809

@ulgensulgens marked this pull request as draftNovember 2, 2025 11:11
It was defined in testenv.deps for tox, which makes it a literal testing requirementThe version requirement is copied from pyproject.toml
These filters are already applied by GenericAPIView.filter_queryset()
@ulgensulgensforce-pushed thefix-cursor-pagination-ordering branch 2 times, most recently from0053ad4 toa8b6130CompareNovember 4, 2025 12:11
@ulgensulgensforce-pushed thefix-cursor-pagination-ordering branch froma8b6130 toe03bd60CompareNovember 5, 2025 13:34
@auvipyauvipy added this to the3.17 milestoneNov 5, 2025
Copy link
Collaborator

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

may be it would be better, if you link other relevant or somewhat relevant issues in the description

@ulgens
Copy link
ContributorAuthor

@auvipy I will do, but the PR needs some more serious work. It turned out, our cursor implementation makes heavy usage of "detect ordering from the view config & request" logic while completely ignoring the ordering provided by queryset or any other 3rd party, which makes it significantly harder to customize. I'm afraid the appropriate fix will need a partial rewrite of the cursor mechanism.

@browniebroke
Copy link
Member

browniebroke commentedNov 7, 2025
edited
Loading

the PR needs some more serious work. It turned out, our cursor implementation makes heavy usage of "detect ordering from the view config & request" logic while completely ignoring the ordering provided by queryset or any other 3rd party, which makes it significantly harder to customize. I'm afraid the appropriate fix will need a partial rewrite of the cursor mechanism.

Ok that's good to know. With what you learned trying this implementation/fix, do you feel like our docs are explaining this limitation well enough? If not, should we add a note/warning outlining it better? From what you wrote, it feels to me like a proper fix will take longer

auvipy reacted with thumbs up emoji

@ulgens
Copy link
ContributorAuthor

do you feel like our docs are explaining this limitation well enough?

I'm not sure if we want to mention 3rd parties in that part of the docs but I think it would be better if something about django-filters ordering - CursorPagination incompatability mentioned in the docs.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@auvipyauvipyauvipy requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.17

Development

Successfully merging this pull request may close these issues.

3 participants

@ulgens@browniebroke@auvipy

[8]ページ先頭

©2009-2025 Movatter.jp