Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Add MaxFileSizeValidator and MinFileSizeValidator for file size constraints#9738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mahdirahimi1999 wants to merge2 commits intoencode:masterChoose a base branch frommahdirahimi1999:feature/file-size-validators
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Add MaxFileSizeValidator and MinFileSizeValidator for file size constraints#9738
mahdirahimi1999 wants to merge2 commits intoencode:masterfrommahdirahimi1999:feature/file-size-validators
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add two new validators for enforcing file size constraints on uploaded files:- MaxFileSizeValidator: Ensures files do not exceed a maximum size (in bytes)- MinFileSizeValidator: Ensures files meet a minimum size (in bytes)Both validators:- Support custom error messages and codes- Are deconstructible for migrations- Include comprehensive unit and integration tests- Work with FileField and ImageField- Follow DRF conventions and patterns
- Remove top-level PIL import from tests/test_validators.py- Conditionally import PIL inside image-related tests and skip them if Pillow is unavailable
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add file size validators for FileField and ImageField
Adds two new validators to enforce file size constraints on uploaded files:
Background
In many of our DRF and Django projects, we work extensively with FileField and ImageField and need to validate file sizes. I've been creating these validators locally, and other developers have been implementing similar solutions. I thought it would be beneficial to create a standardized class that can be added to DRF and used across our projects.
New Validators
Features
Usage
Implementation
rest_framework/validators.py
docs/api-guide/validators.md
Error Codes
max_file_size
- Default for MaxFileSizeValidatormin_file_size
- Default for MinFileSizeValidator