Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Update test matrix to use Django 5.2 stable version#9679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
browniebroke left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, small clean-up. Although this technically doesn't change anything (tox started to pick up the Django 5.2 final as soon as it got released).
TGoddessana commentedApr 3, 2025
Ah, we specified a minimum version, so I guess that's how it works :) Thanks for reviewing the PR! |
browniebroke commentedApr 3, 2025
There is some satisfaction of having all versions consistent... We could switch to |
ulgens commentedApr 3, 2025
Not sure about the benefit with |
browniebroke commentedApr 3, 2025
Less churn: we update the matrix once when first adding support and don't bother with following up with other PRs when the final version is out |
TGoddessana commentedApr 4, 2025
Yeah, I think it's more of a coding convention than a technical issue, and once you've chosen that convention, I think we'll have fewer problems writing or reviewing code like this in the future. Ideally, the DRF should be released along with the major release of Django, so we could choose the following workflow:
|
5c21fa7 intoencode:masterUh oh!
There was an error while loading.Please reload this page.
TGoddessana commentedApr 4, 2025
Thanks for reviewing my PR, all! :) |
Description
Now that django 5.2 is generally available, update the tox test from using a beta version of Django 5.2 to the general release.