Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
add django 5.2a1 initial support#9634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
browniebroke commentedJan 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Looking atthe release notes the main thing as strikes me as might need extra work is the composite primary key support. Not necessarily forright now but would be nice to get it added/covered before 5.2 final is released... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we also update the docs?
django-rest-framework/docs/index.md
Line 90 in78e0b84
| * Django (4.2, 5.0, 5.1) |
Regarding composite primary key support, I think that is out of scope of this PR for now. Also the composite primary key based other PR like composite ForeignKey, GFK, admin support are not merged yet. So we should keep this PR lean, just to make sure current tests pass with it. And we handle the brand new features in separate PR |
Agreed |
Does this mean the repository is open for feature contributions again? |
The repo is open to new python and django core compatibility features always. Like django ORM compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Once the home page of the docs are updated, this is good for me 👍🏻
I think the page of the doc automatically builds from the readme. But I might be wrong |
Ipointed at the source used to generate the docs home page. That markdown file being is source control, I doubt it's itself generated. |
No problem, updating it! thanks |
| {py310}-{django42,django50,django51,djangomain} | ||
| {py311}-{django42,django50,django51,djangomain} | ||
| {py312}-{django42,django50,django51,djangomain} | ||
| {py313}-{django51,djangomain} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If these changes removing 5.0 from the test matrix, shouldn't it be removed from thedocs/index.md too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is not necessary
f30c0e2 intoencode:masterUh oh!
There was an error while loading.Please reload this page.
No description provided.