The exception handler call "connections.all()". This creates a database connection to all defined databases. As a small optimization you can use "connections.all(initialized_only=True)" to rollback only the database to which the current thread has open connections.

(My application can have many databases defined, and this loop is identified as a source of many idle database connections)

Note: Before submitting a code change, please review ourcontributing guidelines.

Description

Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please userefs #... in the description of the pull request.

set_roll_back should only rollback initialized connections

cad0ad0

The exception handler call "connections.all()". This creates a database connection to all defined databases. As a small optimization you can use "connections.all(initialized_only=True)" to rollback only the database to which the current thread has open connections.(My application can have many databases defined, and this loop is identified as a source of many idle database connections)

auvipy reviewed

Dec 14, 2024

View reviewed changes

Copy link

Collaborator

auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is it possible to add tests to avoid regression?

Copy link

Author

jdetaeye commentedDec 16, 2024

@auvipy I just looked into updating

django-rest-framework/tests/test_views.py

Line 113 ina8595a8

deftest_class_based_view_exception_handler(self):

with such a test. I failed creating a test case demonstrating the fix (maybe related to the in memory sqlite database used by the test?). Sorry, I won't be able to provide a test.

Copy link

stalebot commentedApr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stalebot added the stale label

Apr 26, 2025

auvipy requested a review fromCopilot

April 27, 2025 08:43

CopilotAI reviewed

Apr 27, 2025

View reviewed changes

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This pull request optimizes the rollback process by limiting the rollback to initialized database connections only.

Updated the set_rollback function to use the "initialized_only" flag
Reduces unnecessary database connection instantiation during exception handling

auvipy requested a review froma team

April 27, 2025 08:44

stalebot removed the stale label

Apr 27, 2025

peterthomassen approved these changes

Apr 28, 2025

View reviewed changes

Copy link

Collaborator

peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks very reasonable, and I've followed the flow into what Django does when this is called, and it lgtm.

I've also verified that this issupported by all Django releases we rely on. I guess we didn't have this initially because it was only introduced in Django 4.1.

Copy link

stalebot commentedJul 19, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.