Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Drop coreapi support for DRF 3.17#9583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
TGoddessana wants to merge17 commits intoencode:master
base:master
Choose a base branch
Loading
fromTGoddessana:drop-coreapi-support

Conversation

TGoddessana
Copy link
Contributor

Description

refs#8453

As discussed in#8453, we are deprecating the coreapi for drf 3.17.

I read the discussion in detail, and I'm wondering if it was decided to “leave all schema generation logic in the library that generates the schema (drf-spectacular), and drf will not be involved in schema generation” (drf-spectacular will be part of drf?) The comments in the linked discussion say that...

Yes. The idea would be to leave (just) the extension points in place, as they are.

onny reacted with thumbs up emojiulgens reacted with thumbs down emoji
@TGoddessana
Copy link
ContributorAuthor

TGoddessana commentedMar 21, 2025
edited
Loading

Question while working with PR.

Thedocumentation says: “Support for generating default schemas will be moved to a separate package and then removed”. For this PR, should we remove coreapi and everything related to it, or all code related to the wholerest_framework/schemas/ package?

If you need to remove everything related to schemas from theRest Framework, you can remove most of the code, tests, etc. in/schemas. What do you team think about this?

@TGoddessana
Copy link
ContributorAuthor

@auvipy I'm sorry if the tags are annoying. But this is the only place we can make design decisions about PR, and I'd love to hear your thoughts on what I should do..

@auvipy
Copy link
Member

yes please fix the merge conflicts as we have to remove it

@TGoddessana
Copy link
ContributorAuthor

I guess this is where we need to make a decision on where we stop supporting it... For example, should we remove all schema-related references in rest_framework.settings since schema generation will stop?

The documentation certainly mentions that we will be removing API documentation, but I'm confused if removing all code likeschemas.utils orrenderers.CoreJSONRenderer is included in this scope.

@TGoddessana
Copy link
ContributorAuthor

image

For example, the APIView class defaults to the DefaultSchema() class that was included in the schema package.

If we were to remove schema generation, would it be right to remove these codes as well?

@browniebrokebrowniebroke added this to the3.17 milestoneJul 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@auvipyauvipyAwaiting requested review from auvipy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.17
Development

Successfully merging this pull request may close these issues.

3 participants
@TGoddessana@auvipy@browniebroke

[8]ページ先頭

©2009-2025 Movatter.jp