Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Fix docs typo in Serializers Validators#9563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
auvipy approved these changesOct 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull Request Description
Fix: Correct example for UniqueTogetherValidator in serializer documentation
The example provided for using
UniqueTogetherValidatorin the serializer documentation currently uses anIntegerFieldfor theroom_numberfield. This is incorrect, asUniqueTogetherValidatoris designed to work with relational fields, not integer fields.This pull request replaces the
IntegerFieldwith aChoiceFieldfor theroom_numberfield, which is a more appropriate field type for this scenario. This change ensures that the example accurately demonstrates how to useUniqueTogetherValidatorwith related fields.Changes Made:
room_numberfield has been changed from:This minor correction will help users understand how to properly implement
UniqueTogetherValidatorin their serializers.django-rest-framework/docs/api-guide/serializers.md
Line 236 ind3dd45b