Dec 14, 2024 · Sep 11, 2024 · Sep 11, 2024 · Sep 11, 2024 · Oct 14, 2024 · Oct 14, 2024
diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py
                default = timezone.now
            elif unique_constraint_field.has_default():
                default = unique_constraint_field.default
            elif unique_constraint_field.null:
                default = None
            else:
                default = empty

diff --git a/tests/test_validators.py b/tests/test_validators.py
        serializer = NullUniquenessTogetherSerializer(data=data)
        assert serializer.is_valid()

    def test_ignore_validation_for_missing_nullable_fields(self):
        data = {
            'date': datetime.date(2000, 1, 1),
            'race_name': 'Paris Marathon',
        }
        serializer = NullUniquenessTogetherSerializer(data=data)
        assert serializer.is_valid(), serializer.errors

    def test_do_not_ignore_validation_for_null_fields(self):
        # None values that are not on fields part of the uniqueness constraint
        # do not cause the instance to skip validation.
        ]


 class UniqueConstraintNullableModel(models.Model):
    title = models.CharField(max_length=100)
    age = models.IntegerField(null=True)
    tag = models.CharField(max_length=100, null=True)

    class Meta:
        constraints = [
            # Unique constraint on 2 nullable fields
            models.UniqueConstraint(name='unique_constraint', fields=('age', 'tag'))
        ]


 class UniqueConstraintSerializer(serializers.ModelSerializer):
    class Meta:
        model = UniqueConstraintModel
        fields = '__all__'


 class UniqueConstraintNullableSerializer(serializers.ModelSerializer):
    class Meta:
        model = UniqueConstraintNullableModel
        fields = ('title', 'age', 'tag')


 class TestUniqueConstraintValidation(TestCase):
    def setUp(self):
        self.instance = UniqueConstraintModel.objects.create(
        ids_in_qs = {frozenset(v.queryset.values_list(flat=True)) for v in validators if hasattr(v, "queryset")}
        assert ids_in_qs == {frozenset([1]), frozenset([3])}

    def test_nullable_unique_constraint_fields_are_not_required(self):
        serializer = UniqueConstraintNullableSerializer(data={'title': 'Bob'})
        self.assertTrue(serializer.is_valid(), serializer.errors)
        result = serializer.save()
        self.assertIsInstance(result, UniqueConstraintNullableModel)


 # Tests for `UniqueForDateValidator`
 # ----------------------------------
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1490,6 +1490,8 @@ def get_uniqueness_extra_kwargs(self, field_names, declared_fields, extra_kwargs
		default = timezone.now
		elif unique_constraint_field.has_default():
		default = unique_constraint_field.default
		elif unique_constraint_field.null:
		default = None
		else:
		default = empty

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -441,6 +441,14 @@ def test_ignore_validation_for_null_fields(self):
		serializer = NullUniquenessTogetherSerializer(data=data)
		assert serializer.is_valid()

		def test_ignore_validation_for_missing_nullable_fields(self):
		data = {
		'date': datetime.date(2000, 1, 1),
		'race_name': 'Paris Marathon',
		}
		serializer = NullUniquenessTogetherSerializer(data=data)
		assert serializer.is_valid(), serializer.errors

		def test_do_not_ignore_validation_for_null_fields(self):
		# None values that are not on fields part of the uniqueness constraint
		# do not cause the instance to skip validation.
Expand DownExpand Up		@@ -539,12 +547,30 @@ class Meta:
		]


		class UniqueConstraintNullableModel(models.Model):
		title = models.CharField(max_length=100)
		age = models.IntegerField(null=True)
		tag = models.CharField(max_length=100, null=True)

		class Meta:
		constraints = [
		# Unique constraint on 2 nullable fields
		models.UniqueConstraint(name='unique_constraint', fields=('age', 'tag'))
		]


		class UniqueConstraintSerializer(serializers.ModelSerializer):
		class Meta:
		model = UniqueConstraintModel
		fields = '__all__'


		class UniqueConstraintNullableSerializer(serializers.ModelSerializer):
		class Meta:
		model = UniqueConstraintNullableModel
		fields = ('title', 'age', 'tag')


		class TestUniqueConstraintValidation(TestCase):
		def setUp(self):
		self.instance = UniqueConstraintModel.objects.create(
Expand DownExpand Up		@@ -611,6 +637,12 @@ def test_single_field_uniq_validators(self):
		ids_in_qs = {frozenset(v.queryset.values_list(flat=True)) for v in validators if hasattr(v, "queryset")}
		assert ids_in_qs == {frozenset([1]), frozenset([3])}

		def test_nullable_unique_constraint_fields_are_not_required(self):
		serializer = UniqueConstraintNullableSerializer(data={'title': 'Bob'})
		self.assertTrue(serializer.is_valid(), serializer.errors)
		result = serializer.save()
		self.assertIsInstance(result, UniqueConstraintNullableModel)


		# Tests for `UniqueForDateValidator`
		# ----------------------------------
Expand Down