Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Fix raising on nullable fields part ofUniqueConstraint
#9531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix raising on nullable fields part ofUniqueConstraint
#9531
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
any progress here?
Not really, I've dropped the ball a bit on this one. Will try to make some progress... |
SorianoMarmol commentedOct 23, 2024
Is a new version expected with this fix and others related like#9360 ? The support for UniqueConstraint is not complete and may cause issues… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
a8595a8
intoencode:masterUh oh!
There was an error while loading.Please reload this page.
thanks! |
mdellweg commentedApr 4, 2025
I'm not entirely sure under which circumstances, but this change turns a I'll keep investigating. |
mdellweg commentedApr 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Here is a (minimal???) reproducer: deftest_tba():classTestModel(models.Model):field_1=models.IntegerField(null=True)field_2=models.IntegerField(null=True)classMeta:unique_together= (("field_1","field_2"),)classTestSerializer(serializers.ModelSerializer):field_1=serializers.SerializerMethodField()defget_field_1(self)->str:return"TEST"classMeta:model=TestModelfields= ["field_1","field_2"]fields=TestSerializer().fieldsassertisinstance(fields["field_1"],serializers.SerializerMethodField)
|
Seeing the same thing in my codebase when upgrading to 3.16! |
Uh oh!
There was an error while loading.Please reload this page.
Description
Fix#9378