Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Add official support for Django 5.1#9514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Following the supported Python versions:https://docs.djangoproject.com/en/stable/faq/install/
[testenv:py38-djangomain] | ||
ignore_outcome = true | ||
[testenv:py39-djangomain] | ||
ignore_outcome = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We don't test Django main against 3.8 or 3.9 so this is unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
right
Should we try to fix the issue with the new |
I think we should include that in this PR |
browniebroke commentedAug 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I initially went with a custom Additionally, I struggled a bit to test that solution as I couldn't find out a way to configure test views with a non-default I took a step back and realised that DRF already offered a way to achieve what What do people think of the approach? |
RobKuipers commentedAug 30, 2024
Very nice solution. I feel |
Added some more integration-like type of tests to make sure every type of views are covered: class based views, function based views, viewsets and viewsets actions. |
2ede857
intoencode:masterUh oh!
There was an error while loading.Please reload this page.
cjwatson commentedJan 2, 2025
Is there a plan to make a new release to PyPI soon with this change? Debian is currently in the process of switching to Python 3.13 by default, which either requires Django 5.1 or some backporting of patches. I'm wondering whether it makes more sense to attempt to backport this patch to REST framework 3.15.2, or something else. |
Uh oh!
There was an error while loading.Please reload this page.
Description
Add Django 5.1 to the CI matrixfollowing the supported Python versions and declare official support.