Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

tests: Check urlpatterns after cleanups#9400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
auvipy merged 1 commit intoencode:masterfromstanislavlevin:issue_9399
May 7, 2024

Conversation

stanislavlevin
Copy link
Contributor

According to docs:
https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup

Add a function to be called after tearDownClass() to cleanup resources
used during the test class. Functions will be called in reverse order to
the order they are added (LIFO).

This was revealed with recent change in pytest (8.2.0):

pytest-dev/pytest#11728: For unittest-based tests, exceptions during
class cleanup (as raised by functions registered with
TestCase.addClassCleanup) are now reported instead of silently failing.

check_urlpatterns is called beforecleanup_url_patterns and fails (problem was hidden bypytest < 8.2.0).

doClassCleanups can be used instead to check after-cleanup state:

https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups

This method is called unconditionally after tearDownClass(), or after
setUpClass() if setUpClass() raises an exception.

It is responsible for calling all the cleanup functions added by
addClassCleanup(). If you need cleanup functions to be called prior to
tearDownClass() then you can call doClassCleanups() yourself.

Fixes:#9399

According to docs:https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup> Add a function to be called after tearDownClass() to cleanup resources  used during the test class. Functions will be called in reverse order to  the order they are added (LIFO).This was revealed with recent change in pytest (`8.2.0`):>pytest-dev/pytest#11728: For unittest-based tests, exceptions during  class cleanup (as raised by functions registered with  TestCase.addClassCleanup) are now reported instead of silently failing.`check_urlpatterns` is called before `cleanup_url_patterns` and fails(problem was hidden by `pytest < 8.2.0`).`doClassCleanups` can be used instead to check after-cleanup state:https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups> This method is called unconditionally after tearDownClass(), or after  setUpClass() if setUpClass() raises an exception.  It is responsible for calling all the cleanup functions added by  addClassCleanup(). If you need cleanup functions to be called prior to  tearDownClass() then you can call doClassCleanups() yourself.Fixes:encode#9399Signed-off-by: Stanislav Levin <slev@altlinux.org>
@auvipyauvipy merged commit36d5c0e intoencode:masterMay 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@auvipyauvipyauvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[self-tests] cleanup order ofTestUrlPatternTestCase
2 participants
@stanislavlevin@auvipy

[8]ページ先頭

©2009-2025 Movatter.jp