Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
tests: Check urlpatterns after cleanups#9400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
According to docs:https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup> Add a function to be called after tearDownClass() to cleanup resources used during the test class. Functions will be called in reverse order to the order they are added (LIFO).This was revealed with recent change in pytest (`8.2.0`):>pytest-dev/pytest#11728: For unittest-based tests, exceptions during class cleanup (as raised by functions registered with TestCase.addClassCleanup) are now reported instead of silently failing.`check_urlpatterns` is called before `cleanup_url_patterns` and fails(problem was hidden by `pytest < 8.2.0`).`doClassCleanups` can be used instead to check after-cleanup state:https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups> This method is called unconditionally after tearDownClass(), or after setUpClass() if setUpClass() raises an exception. It is responsible for calling all the cleanup functions added by addClassCleanup(). If you need cleanup functions to be called prior to tearDownClass() then you can call doClassCleanups() yourself.Fixes:encode#9399Signed-off-by: Stanislav Levin <slev@altlinux.org>
auvipy approved these changesMay 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to docs:
https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup
This was revealed with recent change in pytest (
8.2.0
):check_urlpatterns
is called beforecleanup_url_patterns
and fails (problem was hidden bypytest < 8.2.0
).doClassCleanups
can be used instead to check after-cleanup state:https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups
Fixes:#9399