Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleanup#9393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
peterthomassen merged 9 commits intomasterfrom20240426_requirements
Apr 30, 2024
Merged

Cleanup#9393

peterthomassen merged 9 commits intomasterfrom20240426_requirements
Apr 30, 2024

Conversation

@peterthomassen
Copy link
Collaborator

@peterthomassenpeterthomassen commentedApr 26, 2024•
edited
Loading

Asdiscussed, this removes support for Django < 4.2 and Python < 3.8.

Further changes:

  • code cleanup
  • docs updates
  • dependency bumps
  • remove Windows line endings

onegreyonewhite and hudy0 reacted with thumbs up emoji
@peterthomassenpeterthomassen marked this pull request as ready for reviewApril 26, 2024 14:10
@peterthomassenpeterthomassen marked this pull request as draftApril 26, 2024 14:17
@peterthomassenpeterthomassen marked this pull request as ready for reviewApril 26, 2024 15:09
@peterthomassenpeterthomassenforce-pushed the20240426_requirements branch 3 times, most recently from8fb2a11 to8030a12CompareApril 26, 2024 16:05
@peterthomassenpeterthomassen changed the title20240426 requirementsCleanupApr 26, 2024
@peterthomassen
Copy link
CollaboratorAuthor

This has gotten a little larger due to the last commit, but don't get scared, it's just whitespace changes ;-) Ready for review.

@auvipyauvipy self-requested a reviewApril 27, 2024 05:32
Copy link
Contributor

@lovelydinosaurlovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wonderful, thanks.

but don't get scared, it's just whitespace changes

In general let's try to isolate changes as much as possible. The easier it is to review, the less likely we are to have sneaky errors creeping in. 😅

@peterthomassenpeterthomassen merged commit9d4ed05 intomasterApr 30, 2024
@peterthomassenpeterthomassen deleted the 20240426_requirements branchApril 30, 2024 16:29
@peterthomassen
Copy link
CollaboratorAuthor

@tomchristie It looks like the docs changes from this PR have not been deployed onhttps://www.django-rest-framework.org/. How is that kicked off?

@lovelydinosaur
Copy link
Contributor

Currently we push docs changes as part of releases.

@AlvaroVega
Copy link
Contributor

Asdiscussed, this removes support for Django < 4.2 and Python < 3.8.

Maybe this should be included in release notes?

@peterthomassen
Copy link
CollaboratorAuthor

Yes, probably. Sorry about that omission. Would you be able to create a PR?

@AlvaroVega
Copy link
Contributor

Yes, probably. Sorry about that omission. Would you be able to create a PR?

Sure:#9451

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lovelydinosaurlovelydinosaurlovelydinosaur approved these changes

@auvipyauvipyAwaiting requested review from auvipy

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@peterthomassen@lovelydinosaur@AlvaroVega@browniebroke@auvipy@TomNewChao
[8]ページ先頭
©2009-2025 Movatter.jp