Fixed #5363 -- HTML5 datetime-local valid format HTMLFormRenderer#9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

mgaligniana wants to merge1 commit intoencode:master

base:master

Choose a base branch

frommgaligniana:issue-5363

Open

Fixed #5363 -- HTML5 datetime-local valid format HTMLFormRenderer#9365

mgaligniana wants to merge1 commit intoencode:masterfrommgaligniana:issue-5363

Conversation

Copy link

Contributor

mgaligniana commentedApr 4, 2024•
edited
Loading

Description

Hi!

This PR deletes the [milli|micro]seconds part of aDateTimeField input atHTMLFormRenderer to avoid break in browsers:

refs#5363

Fixedencode#5363-- HTML5 datetime-local valid format HTMLFormRenderer

c967a6f

Copy link

ContributorAuthor

mgaligniana commentedMay 27, 2024

Hi@auvipy! Following your comment on#5363 (comment) I ask if you could do the review! Thank you!

auvipy self-requested a review

May 27, 2024 16:08

auvipy requested a review froma team

June 10, 2024 07:08

peterthomassen suggested changes

Jun 10, 2024

View reviewed changes

rest_framework/renderers.py

		# The format of an input type="datetime-local" is "yyyy-MM-ddThh:mm"
		# followed by optional ":ss" or ":ss.SSS", so remove [milli\|micro]seconds
		# to avoid browser error.
		field.value = "".join(field.value.rstrip('Z').split(".")[:1])

Copy link

Contributor

peterthomassenJun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The millisecond part should be retained, as it's a valid part of the format.

Copy link

stalebot commentedApr 27, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.