Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

3.15 Release#9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tomchristie merged 71 commits intomasterfrommath-a3k-315_rn
Mar 16, 2024
Merged

3.15 Release#9210

tomchristie merged 71 commits intomasterfrommath-a3k-315_rn
Mar 16, 2024

Conversation

tomchristie
Copy link
Member

Reviewing#8794.

Starting point, I've reviewed the release notes, and cleaned up items that shouldn't be included...

  • Docs changes should not be part of our release notes.
  • Project workflow changes should not be part of our release notes.
  • Test changes should not be part of our release notes.

Our release notes should reflect changes to the released package version.
So... behavioural changes that users may need to be aware of.

Project documentation, workflow, and testing isn't part of that and shouldn't be part of our release notes.

xiaobao0505, lvii, dethos, gdvalderrama, LCEnzo-QCerris, gabn88, shuuji3, gegoune, and jetli reacted with thumbs up emoji
math-a3kand others added30 commitsSeptember 13, 2023 11:34
- Add docs/community/3.15-announcement.md- Update docs/community/release-notes.md- Update mkdocs.ymlCo-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@tomchristie
Copy link
MemberAuthor

Anything else blocking us from merging this?

@TGoddessana
Copy link
Contributor

Shouldthis milestone be resolved and merged?

@browniebroke
Copy link
Member

Anything else blocking us from merging this?

Not sure if a blocker, but you might want to update that sentence with -at least- an updated date:

At the Internet, on January 12th, 2024, with 135 commits 107 authors, we are happy to announce the release of Django REST framework 3.15.

@tomchristie
Copy link
MemberAuthor

you might want to update that

Okay, someone want to propose a release date and make a +/- suggestion?

TGoddessana reacted with eyes emoji

@auvipyauvipy self-requested a reviewMarch 10, 2024 11:58
@TGoddessana
Copy link
Contributor

This is the final step to release, right? If so, the sooner the better, but I think you'll want to review your release process and set your own time to release.

willyamrb reacted with rocket emojixiaobao0505 and cyx2000 reacted with eyes emoji

@tomchristie
Copy link
MemberAuthor

Okay, I'd suggest March 15th... perhaps someone could issue a +/- suggestion and we plan on making the release then?

TGoddessana, cyx2000, adamgyulavari, AbdelazizTina-dev, kalip60, stoiet, beltekylevi, shuuji3, sevdog, browniebroke, and 2 more reacted with thumbs up emojiadamgyulavari, AbdelazizTina-dev, kalip60, beltekylevi, browniebroke, xiaobao0505, and SaravananRamanathan reacted with heart emojiadamgyulavari, AbdelazizTina-dev, horvdan, beltekylevi, browniebroke, xiaobao0505, and SupImDos reacted with rocket emoji

Co-authored-by: JAEGYUN JUNG <twicegoddessana1229@gmail.com>
* Fixes `BrowsableAPIRenderer` for usage with `ListSerializer`. [[#7530](https://github.com/encode/django-rest-framework/pull/7530)]
* Change semantic of `OR` of two permission classes [[#7522](https://github.com/encode/django-rest-framework/pull/7522)]
* Remove dependency on `pytz` [[#8984](https://github.com/encode/django-rest-framework/pull/8984)]
* Fix validation for ListSerializer [[#8979](https://github.com/encode/django-rest-framework/pull/8979)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#8979 is marked as "breaking change" and the fix for that (#9244) is not merged yet. It should be noted in the release notes this is abreaking-change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#8979 is marked as "breaking change" and the fix for that (#9244) is not merged yet. It should be noted in the release notes this is abreaking-change.

@TGoddessana please see same implemented @, thank you,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Although I'm not a maintainer, I'm very interested in the maintenance of the project, so I took a look at the issues.

  1. one PR (Fix validation for ListSerializer #8979) that solves the original issue (Invalidself.instance when validating the serializer usingmany=True #8926) seems to have been merged already, but the better implementation (Improve ListSerializer #9244) is still not fully resolved based on the last comment in the issue.

  2. so which decision do we make?

Would love to hear your thoughts@tomchristie 🥲

Copy link
Contributor

@sevdogsevdogMar 13, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMO the problem is that#8926 was addressed ignoring the advice regarding"Customizing multiple update"

By default theListSerializer class does not support multiple updates. This is because the behavior that should be expected for insertions and deletions is ambiguous.

To support multiple updates you'll need to do so explicitly. When writing your multiple update code make sure to keep the following in mind:

  • How do you determine which instance should be updated for each item in the list of data?
  • How should insertions be handled? Are they invalid, or do they create new objects?
  • How should removals be handled? Do they imply object deletion, or removing a relationship? Should they be silently ignored, or are they invalid?
  • How should ordering be handled? Does changing the position of two items imply any state change or is it ignored?

You will need to add an explicit id field to the instance serializer. The default implicitly-generated id field is marked as read_only. This causes it to be removed on updates. Once you declare it explicitly, it will be available in the list serializer's update method.

Thus the proposed solution (#8979) only addesses a single use case while ignoring out many others which are now not supported by the framework. For example: usingListSerializer to perform in a bulk request a "create-update-delete" of a list of objects which was possible before this change.

PS: there is also an issue with the current implementation ofListSerializer when validating instances and just use "index" to choose which instance will be associated to which data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was thinking about reverting that for this release

sevdog, browniebroke, and TGoddessana reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#9283 let me know your thoughts, and we can wait for a better fix in future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If this change is not released in 3.15, which release do you think is the right one to fix and release it in: 3.16 or 3.15.1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if it is just reverted it will not be included in 3.15, as it is a big thing, it should be included in a major release like 3.16/3.17

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just want to avoid including any not fully functional feature for 3.15

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just want to avoid including any not fully functional feature for 3.15

I agree with you. Thank you for your efforts!

auvipy reacted with thumbs up emoji
Co-authored-by: JAEGYUN JUNG <twicegoddessana1229@gmail.com>
@tomchristie
Copy link
MemberAuthor

Okay, I think we're good to release here?

xiaobao0505, TGoddessana, ulgens, MicheleV, cclauss, arkapratimc, and browniebroke reacted with hooray emoji

@tomchristietomchristie changed the titleRelease notes for 3.153.15 ReleaseMar 15, 2024
@tomchristie
Copy link
MemberAuthor

tomchristie commentedMar 15, 2024
edited
Loading

Okay, I might have enough time to roll this release later today... (on schedule☺️) unless there's any objections?
Minor query from my perspective... are we okay with the supported range of Python & Django, or should we keep them more constrained?... (Example... We could bump up the formal support to Django 4.0 and Python 3.8 in our docs without actually changing anything else)

foarsitter, Gnonpi, xiaobao0505, TGoddessana, browniebroke, and medbenmakhlouf reacted with hooray emojibrowniebroke reacted with eyes emoji

@cclauss
Copy link
Contributor

cclauss commentedMar 15, 2024
edited
Loading

https://docs.djangoproject.com/en/stable/faq/install/#what-python-version-can-i-use-with-django still supports Django 3.2 (at least untilnext month).

However, I think we could safely drop support for Python < 3.8 (https://devguide.python.org/versions) because supporting five different versions of CPython is enough effort.

Perhaps release thisas is and then in a few months create a release that drops Django v3.x and also Python < 3.8.

Copy link
Member

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we should just keep supporting as many versions as possible in this release as it is a long overdue. after that we can decide which versions we should drop.

cclauss, TGoddessana, sevdog, browniebroke, cyx2000, cosmosgenius, tfranzel, xiaobao0505, lvii, and michaeloliverx reacted with thumbs up emoji
@auvipyauvipy added this to the3.15 milestoneMar 15, 2024
@tomchristietomchristie merged commit2d8e9ad intomasterMar 16, 2024
@tomchristietomchristie deleted the math-a3k-315_rn branchMarch 16, 2024 17:21
@tomchristie
Copy link
MemberAuthor

Okay, we're merged add ready to publish.
The deploy to pypi will need to wait until monday now...

xiaobao0505, shuuji3, sevdog, sliverc, lvii, and qqii reacted with hooray emojixiaobao0505, TGoddessana, alexandroqc, browniebroke, sevdog, tfranzel, lvii, qqii, and pauloxnet reacted with rocket emoji

@tfranzel
Copy link
Member

Thank you guys for pushing this out the door. Much appreciated!

Now that the pypi release is done, we should probably also craft a github release for 3.15.0.

TGoddessana, lvii, ZeyadMoustafaKamal, and mdefeche reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deronnaxderonnaxderonnax left review comments

@cclausscclausscclauss approved these changes

@sevdogsevdogsevdog left review comments

@math-a3kmath-a3kmath-a3k left review comments

@tonyvg2013tonyvg2013tonyvg2013 left review comments

@TGoddessanaTGoddessanaTGoddessana requested changes

@auvipyauvipyauvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15
Development

Successfully merging this pull request may close these issues.

13 participants
@tomchristie@auvipy@browniebroke@math-a3k@ryanisnan@lvii@Kludex@TGoddessana@cclauss@tfranzel@deronnax@sevdog@tonyvg2013

[8]ページ先頭

©2009-2025 Movatter.jp