looks like a nice improvment

can we avoid at least one breaking change

• Split by spaces only by spaces, considering quoteing (breaking change) --- and keep both? if it is not too hard?

can we avoid at least one breaking change

• Split by spaces only by spaces, considering quoteing (breaking change) --- and keep both? if it is not too hard?

This could be interesting, however it should be defined the order of split logics due to howsmart_split works and which kind of user experience is expected. Just to give an example, consider the following search:

'"hello, world" can I,help you'

Withonlysmart_split this becomes

['hello, world','can','I,help','you']

Maybe a good compromise would be:

• if comma is inside quotes, do not split
• otherwhise split

With this logic the first search whould become

['hello, world','can','I' ,'help','you']

There is anedge case: what to do if there are one or more commas before or after a quoted sentence?

',"hello, world", what to,,do,?'

I belive that in this case it would be nice tostrip commas from tokens extracted bysmart_split and then yield quoted sentences as the are and split other by comma.

The generator to handle this iteration whould be something like:

defsearch_smart_split(search_terms):forterminsmart_split(search_terms):term=term.strip(',')ifterm.startswith(('"',"'"))andterm[0]==term[-1]:yieldunescape_string_literal(term)else:yieldfrom (sub_termforsub_terminterm.split(',')ifsub_term)

This should parse the latter term into:

['hello, world','what','to','do','?']

Testing the previous approach I encountered an other case which I did not considered before. What to do when there is a quoted phrase followed by other characters:

'"hello, world",found'

Thesmart_split keeps this phrase togheter, so splitting by comma results in

['"hello',' world"','found']

The whitespace is easy and intuitive to remove (IMO), but I am not sure if in this case also the quotes should be removed (thus using.split(' \'"') instead of.split()).

are we going to preserve the old way or going to have option for both new and old ways?

are we going to preserve the old way or going to have option for both new and old ways?

It depends on which mechanism are we willing to provide to select this behaviour. I can think these:

• an attribute on filter class
• an attribute on view
• a settings (which would be global for every view/filter)

from the tests it seems that both type of search is supported in this PR, right? I would like to consider this improvement for 3.15 release

from the tests it seems that both type of search is supported in this PR, right? I would like to consider this improvement for 3.15 release

Yes,search_smart_split does first the split like django.contrib.admin and then splits by comma. The only case in which this would give different results is where the search input is a mixed combination of quoted strings and commas. A simple CSV vaue (ie:an,example,search) would be splitted like it was before.

do you intend to add anything else here or improve anything else?

As of now I belive that this should be fine.

I tried to figure out what could have been added to the docs, but I felt that it was just copy-pasting fron django admin docs without adding any value.

Really nice bit of functionality, thanks... have followed up with#9338.