Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Allow REST_FRAMEWORK.PAGE_SIZE to be overriden in settings#8993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Allow REST_FRAMEWORK.PAGE_SIZE to be overriden in settings#8993
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi! Any news on reviewing this? This is a really simple PR, it should be easy to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we have a related PR here#9107. can you review and share some points for the PR? We are very careful at this moment in adding/exposing new API surface to the framework, so it needs thoughtful process to reach a consensus
Also this will need tests and documentation update |
I'm not sure why the documentation should be updated. This feels like getting the intanded behaviour more than adding a feature. I'm also not sure where to put the tests for that. Can you point me to the relevant file? Would it be |
Hi! Can I have an input here so that this may progress? |
Description
Overriding
REST_FRAMEWORK.PAGE_SIZEwith@override_settingsin tests doesn't override setting, which is disturbing. My opinion is that there are legitimate use cases when you may want to overrideREST_FRAMEWORK.PAGE_SIZEin your tests and paginator should reflect this change.