Jun 13, 2023 · Apr 17, 2023 · Apr 18, 2023 · Apr 18, 2023 · Apr 19, 2023 · Apr 20, 2023
diff --git a/rest_framework/templates/rest_framework/horizontal/select_multiple.html b/rest_framework/templates/rest_framework/horizontal/select_multiple.html
  {% endif %}

 <divclass="col-sm-10">
 <selectmultiple{{field.choices|yesno:",disabled" }}class="form-control"name="{{ field.name }}">
 <selectmultipleclass="form-control"name="{{ field.name }}">
      {% for select in field.iter_options %}
        {% if select.start_option_group %}
 <optgrouplabel="{{ select.label }}">
Original file line number	Diff line number	Diff line change
Expand Up		@@ -11,7 +11,7 @@
		{% endif %}

		<divclass="col-sm-10">
		<selectmultiple{{field.choices\|yesno:",disabled" }}class="form-control"name="{{ field.name }}">
Copy link Collaborator auvipyApr 18, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. how can we determine this won't create any regression? Copy link ContributorAuthor lnagelApr 18, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. From my side I will include the modified template in our current projects. So far this seems to have resolved the issue of forms not loading within 30 seconds that the application server is willing to wait on DRF request processing and the end user getting a gateway timeout. Copy link ContributorAuthor lnagelApr 19, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Another way to reason about this: as long as field.choices are present (field queryset is non-empty), then the select element is not assigned the "disabled" html attribute. Theoretically speaking it should not matter whether a multi-select field without any choices is disabled or enabled - there isn't anything to select. Is anyone aware of some corner case situation that we should be aware of? auvipy reacted with thumbs up emoji Copy link Collaborator auvipyApr 20, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. is it possible to add test coverage for this?
		<selectmultipleclass="form-control"name="{{ field.name }}">
		{% for select in field.iter_options %}
		{% if select.start_option_group %}
		<optgrouplabel="{{ select.label }}">
Expand Down