Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement__eq__ for validators#8925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@max-muoto
Copy link
Contributor

Note: Before submitting this pull request, please review ourcontributing guidelines.

Description

Implement equality operator for validators and add test coverage.

Fixes#8905.

@max-muotomax-muoto marked this pull request as ready for reviewApril 2, 2023 21:13
@auvipyauvipy self-requested a reviewApril 3, 2023 07:15
@auvipyauvipy added this to the3.15 milestoneApr 8, 2023
Copy link
Collaborator

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should we find any place for documentation improvement?

@max-muoto
Copy link
ContributorAuthor

should we find any place for documentation improvement?

I added a sentence on the fact that they implement__eq__ like their Django counterparts in the validation documentation if that suffices. Let me know what you think.

@auvipyauvipy merged commit0d6ef03 intoencode:masterApr 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@auvipyauvipyauvipy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.15

Development

Successfully merging this pull request may close these issues.

Validators do not implement__eq__ method

2 participants

@max-muoto@auvipy

[8]ページ先頭

©2009-2025 Movatter.jp