Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix FilePathField required argument#8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@radekwlsk
Copy link
Contributor

Description

Following on the discussion in#8804 this PR fixesrequired argument lost inFilePathField constructor by making sure it is passed to thesuper().__init__ call with other keyword arguments.

@radekwlsk
Copy link
ContributorAuthor

@auvipy Not sure what the CI error is. Seems that deprecationwarnings are making it fail?

@auvipy
Copy link
Collaborator

can you please check why the CI is failing?? might be unrelated to this PR after checking the error message though

@auvipy
Copy link
Collaborator

I think we should get rid of python 3.6 now from CI

@radekwlsk
Copy link
ContributorAuthor

radekwlsk commentedDec 21, 2022•
edited
Loading

@auvipy Also I wonder if settingallow_blank=False together withrequired=False should remove("", "---------") from path choices. As currently django'sFilePathField will add it wheneverrequired=False and that will make"" a valid choice and skipallow_blank=False.

Not sure of the expected behaviour though, as it is based onChoiceField and that does not supportallow_blank, right?

@auvipy
Copy link
Collaborator

we should align with django mainly

@radekwlsk
Copy link
ContributorAuthor

Waiting for CI fix on master.

Copy link
Collaborator

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just pull from main branch

@radekwlskradekwlskforce-pushed thefix-filepathfield-required branch fromcc50963 to2bd0008CompareJanuary 4, 2023 15:05
@auvipyauvipy added the Bug labelJan 4, 2023
@auvipyauvipy merged commit89d6ce7 intoencode:masterJan 4, 2023
@auvipyauvipy added this to the3.15 milestoneJan 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@auvipyauvipyauvipy approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

3.15

Development

Successfully merging this pull request may close these issues.

2 participants

@radekwlsk@auvipy
[8]ページ先頭
©2009-2025 Movatter.jp