Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added examples to schema of CursorPagination#8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lovelydinosaur merged 2 commits intoencode:masterfromnorbertschuler:patch-1
Oct 11, 2022

Conversation

@norbertschuler
Copy link
Contributor

Fix#8686

Added missing examples for CursorPagination class to disable warnings inhttps://github.com/tfranzel/drf-spectacular and make it consistent with other pagination classes.

Fixencode#8686Added missing examples for CursorPagination class to disable warnings inhttps://github.com/tfranzel/drf-spectacular and make it consistent with other pagination classes.
@lovelydinosaur
Copy link
Contributor

Thanks for this! Yup seems good.

Looks like we've got a test case that checks the schema output, which would need fixing up...

https://github.com/encode/django-rest-framework/actions/runs/3207548339/jobs/5262424890

Let me know if you need a pointer in getting that sorted.

norbertschuler reacted with thumbs up emoji

@norbertschuler
Copy link
ContributorAuthor

Looks like we've got a test case that checks the schema output, which would need fixing up...

Sorry for not having checked that in first place. I have no environment set up to run the test suite rather relying on your GitHub actions. I fixed the test now.

auvipy reacted with hooray emoji

@lovelydinosaurlovelydinosaur merged commit911b207 intoencode:masterOct 11, 2022
@lovelydinosaur
Copy link
Contributor

Great, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nasty warning using CursorPagination with drf-spectacular

2 participants

@norbertschuler@lovelydinosaur

[8]ページ先頭

©2009-2025 Movatter.jp