Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Remove old deprecation classes for 3.14 release#8664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
lovelydinosaur merged 1 commit intoencode:masterfromDavidCain:dcain-deprecations-drf-314Sep 22, 2022
Merged
Remove old deprecation classes for 3.14 release#8664
lovelydinosaur merged 1 commit intoencode:masterfromDavidCain:dcain-deprecations-drf-314Sep 22, 2022
+0 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When DRF 3.14 is released, these exception classes will be meaningless,so we can delete them (this has always been done).A previous PR removed the last incidence of `RemovedInDRF313Warning`,but didn't outright delete the class for fear of shipping a breakingchange:encode#8589
Merged
| pass | ||
| classRemovedInDRF315Warning(PendingDeprecationWarning): |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Worth noting thatPendingDeprecationWarning is probably the wrong parent class, but I made a separate PR for that:#8665
Contributor
lovelydinosaur commentedSep 22, 2022
Great, thank you. |
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull requestDec 3, 2022
When DRF 3.14 is released, these exception classes will be meaningless,so we can delete them (this has always been done).A previous PR removed the last incidence of `RemovedInDRF313Warning`,but didn't outright delete the class for fear of shipping a breakingchange:encode#8589
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DRF 3.14 is released, these exception classes will be meaningless, so we can delete them (this has always been done).
A previous PR removed the last incidence of
RemovedInDRF313Warning, but didn't outright delete the class for fear of shipping a breakingchange:#8589