Wait. Haven't we got both of these wrong? In what context isNotImplemented returned?
Surely it should beraised as an exception.

What code is returning it?

Test - does this unapprove?

You need to "dismiss review" from the panel at the bottom.

Wait. Haven't we got both of these wrong? In what context is NotImplemented returned?
Surely it should be raised as an exception.

What code is returning it?

No, we've got this right, seethe docs:

NotImplemented
A special value which should be returned by the binary special methods (e.g.__eq__(),__lt__(),__add__(),__rsub__(), etc.) to indicate that the operation is not implemented with respect to the other type; may be returned by the in-place binary special methods (e.g.__imul__(),__iand__(), etc.) for the same purpose. It should not be evaluated in a boolean context.NotImplemented is the sole instance of thetypes.NotImplementedType type.
...
Changed in version 3.9: EvaluatingNotImplemented in a boolean context is deprecated. While it currently evaluates as true, it will emit aDeprecationWarning. It will raise aTypeError in a future version of Python.

Gotcha, thanks.

As I said in#7433 (comment) I'm happy to add a test for this case, given some guidance.

Perhaps we're okay with it not having one.
PR#7531 didn't.
Consistency is a virtue, no?

Please rename „r” to „result” or something else.

@wieczorek1990 The change here is consistent with the existing code above.

Thanks,@tomchristie 🙏

I don’t think short names are good code.

Generally agreed.
A pull request changing them forboth cases would be accepted.

@tomchristie Here:#8585