Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Don't evaluate default_timezone unless needed#8531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If you set a custom timezone for a DateTimeField, the functionself.default_timezone() is still called, since fallback params togetattr are still evaluated.This rewrites to use hasattr, so the fallback case is only executed ifit will actually be used. If you render a lot of DateTimeFields in aserializer, the time spent evaluating default_timezone() once for eachof them can accumulate to quite a bit, which is just unused work in thecase where timezone is already specified on the field.
tomchristie approved these changesJun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't have any objection to this.
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull requestDec 3, 2022
If you set a custom timezone for a DateTimeField, the functionself.default_timezone() is still called, since fallback params togetattr are still evaluated.This rewrites to use hasattr, so the fallback case is only executed ifit will actually be used. If you render a lot of DateTimeFields in aserializer, the time spent evaluating default_timezone() once for eachof them can accumulate to quite a bit, which is just unused work in thecase where timezone is already specified on the field.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you set a custom timezone for a DateTimeField, the function
self.default_timezone() is still called, since fallback params to
getattr are still evaluated.
This rewrites to use hasattr, so the fallback case is only executed if
it will actually be used. If you render a lot of DateTimeFields in a
serializer, the time spent evaluating default_timezone() once for each
of them can accumulate to quite a bit, which is just unused work in the
case where timezone is already specified on the field.