Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Properly handle OverflowError in DurationField deserialization#8042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Properly handle OverflowError in DurationField deserialization#8042
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
peterthomassen commentedApr 25, 2022
I think this is still current. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
peterthomassen commentedJul 14, 2022
I think this is still current. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
peterthomassen commentedSep 22, 2022
I think this is still current. |
auvipy left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we have recently merged an identical feature for another field#8725. can you cross check and make amendment accordingly to this PR?
peterthomassen commentedNov 22, 2022
The code looks very similar to me. Which according amendments do you mean? (Would you like to change the logic, or the error message? ( |
auvipy commentedNov 22, 2022
btw, having another look, it seems your code is quite right. can you please pull from master so that the CI triggers with latest changes? |
5c97c3b to86d46c9Comparec458456 toc6eb872Comparepeterthomassen commentedNov 22, 2022
done |
auvipy commentedNov 24, 2022
thank you for your patience |
Related:https://github.com/django/django/pull/8870/files
Note: Before submitting this pull request, please review ourcontributing guidelines.
Description
Properly handle OverflowError in DurationField deserialization. Solution is the same as for the corresponding Django form field.