Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Fix OpenAPI operation name plural appropriately#8017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
lovelydinosaur commentedJun 7, 2021
Certainly going to be neater than what we're currently doing. |
heavenshell commentedJun 7, 2021
Thank you for reviewing! I don't know why CI is failing... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
480f486 to7cf5c19CompareThis issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
auvipy commentedNov 24, 2022
the only build failure is a doc related failure, which does not seem to be related to this PR |
heavenshell commentedNov 24, 2022
@auvipy Thank you so much! 👍 |
tfranzel commentedNov 28, 2022
pretty sure this broke the build by introducing a new hard dependency through the backdoor. see#8781 |
A dependency onencode/django-rest-framework#8017 and latermade less obtrusive byencode/django-rest-framework#8781, butit did not eliminate it. Any usage of the schema generatormust be done in an environment that includes this package.
A dependency onencode/django-rest-framework#8017 and latermade less obtrusive byencode/django-rest-framework#8781, butit did not eliminate it. Any usage of the schema generatormust be done in an environment that includes this package.
`django-rest-framework` has recieved several patches forCSP compatibility, but unfortunately these are not includedin the latest release (3.14.0) and a new release cannot beexpected for a while.As such, we must replace the semantically versioned PyPIreference with a reference to the latest commit on the masterbranch of the package's Git Repository that contains thechanges that we need (do not use `master` since it couldchange in unexpected and incompatible ways).Included in this change is the `inflection` package,unfortunate dependency added byencode/django-rest-framework#8017and later made less obtrusive byencode/django-rest-framework#8781,but it did not eliminate it. Any usage of the schema generatormust be done in an environment that includes this package.Fixes:freelawproject#3020
`django-rest-framework` has recieved several patches forCSP compatibility, but unfortunately these are not includedin the latest release (3.14.0) and a new release cannot beexpected for a while.As such, we must replace the semantically versioned PyPIreference with a reference to the latest commit on the masterbranch of the package's Git Repository that contains thechanges that we need (do not use `master` since it couldchange in unexpected and incompatible ways).Included in this change is the use of `inflection` for theOpenAPI spec's `operationIds`, an unfortunate dependencyadded byencode/django-rest-framework#8017 and later madeless obtrusive byencode/django-rest-framework#8781. Anyusage of the schema generator must be done in an environmentthat includes this package. Additionally, this new approachmakes the generated `operationId` that was `listPersons` into`listPeople`. Thankfully, this is immaterial.Fixes:freelawproject#3020
Description
This PR is re-challenge of#7447
I introducedinflection library to pluralize appropriately.
It would be very grateful to review this 😊
Thank you.