Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

make get_reference public#7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tomchristie merged 2 commits intoencode:masterfromn2ygk:public_get_reference
Jun 6, 2022

Conversation

n2ygk
Copy link
Contributor

Description

Makesschemas.openapi.get_reference public (remove the _) to complement making other methods public such asget_component_name()

hudy0 reacted with thumbs up emoji
@tomchristie
Copy link
Member

It's not immediately obvious to mewhen this'd be useful to have as public API, since it only makes sense to use if you've got referencesoutside of the standard'$ref': '#/components/schemas/{...} space.

Are you able to provide some kind of slimmed down example that'd require this as public API?

@n2ygk
Copy link
ContributorAuthor

n2ygk commentedSep 3, 2020
edited
Loading

@tomchristie

Are you able to provide some kind of slimmed down example that'd require this as public API?

I'm extending get_schema() and so far have two remaining private API calls:_get_reference and_initialise_endpoints

https://github.com/django-json-api/django-rest-framework-json-api/blob/c1ceb7f42b98ee382c11372e72933a8fbdfe9691/rest_framework_json_api/schemas/openapi.py#L547-L559

@tomchristie
Copy link
Member

Okay, so... making it public not because you want to override the behaviour in it, but rather, making it public because your implementation needs to call it? That makes sense I guess.

@n2ygk
Copy link
ContributorAuthor

n2ygk commentedSep 3, 2020 via email
edited
Loading

Yep. Maybe do the same for _initialise_endpoints? I just prefer not to haveto rely on private APIs. I can submit a PR for that as well or add it tothis one if you prefer.
On Thu, Sep 3, 2020 at 10:27 AM Tom Christie ***@***.***> wrote: Okay, so... making it public not because you want to override the behaviour in it, but rather, making it public because your implementation needs to call it? That makes sense I guess. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7515 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBHS57YPOZRPGWDKTD3YDLSD6RV7ANCNFSM4QUYPQVQ> .

@n2ygk
Copy link
ContributorAuthor

@tomchristie should this be inmilestone 3.13 and/or labeledschema generation?

@n2ygk
Copy link
ContributorAuthor

@carltongibson perhaps you can review this and put it on Tom's queue for 3.13?

@stale
Copy link

stalebot commentedApr 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the stale labelApr 28, 2022
@n2ygk
Copy link
ContributorAuthor

This stalebot stuff makes me sad that I wasted effort on submitting PRs.

@stalestalebot removed the stale labelApr 28, 2022
@tomchristie
Copy link
Member

This seems reasonable enough, yes.

@tomchristietomchristie merged commit563a20a intoencode:masterJun 6, 2022
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull requestDec 3, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@n2ygk@tomchristie

[8]ページ先頭

©2009-2025 Movatter.jp