Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
make get_reference public#7515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It's not immediately obvious to mewhen this'd be useful to have as public API, since it only makes sense to use if you've got referencesoutside of the standard Are you able to provide some kind of slimmed down example that'd require this as public API? |
n2ygk commentedSep 3, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'm extending get_schema() and so far have two remaining private API calls: |
Okay, so... making it public not because you want to override the behaviour in it, but rather, making it public because your implementation needs to call it? That makes sense I guess. |
n2ygk commentedSep 3, 2020 via email• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yep. Maybe do the same for _initialise_endpoints? I just prefer not to haveto rely on private APIs. I can submit a PR for that as well or add it tothis one if you prefer. …On Thu, Sep 3, 2020 at 10:27 AM Tom Christie ***@***.***> wrote: Okay, so... making it public not because you want to override the behaviour in it, but rather, making it public because your implementation needs to call it? That makes sense I guess. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7515 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBHS57YPOZRPGWDKTD3YDLSD6RV7ANCNFSM4QUYPQVQ> . |
@tomchristie should this be inmilestone 3.13 and/or labeled |
8ebeb30
to3cff589
Compare@carltongibson perhaps you can review this and put it on Tom's queue for 3.13? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This stalebot stuff makes me sad that I wasted effort on submitting PRs. |
This seems reasonable enough, yes. |
Description
Makes
schemas.openapi.get_reference
public (remove the _) to complement making other methods public such asget_component_name()