Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed Django 2.0 compatibility due todjango.conf.urls.include parameters change.#4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lovelydinosaur merged 1 commit intoencode:masterfromfelixxm:issue-include-change
Jan 30, 2017

Conversation

@felixxm
Copy link
Contributor

Fixed Django 2.0 compatibility due todjango.conf.urls.include parameters change (see Django documentation1.8,2.0).

==================================== ERRORS ====================================____________________ ERROR collecting tests/test_routers.py ____________________tests/test_routers.py:84: in <module>    url(r'^namespaced/', include(namespaced_router.urls, namespace='example')),/django/conf/urls/__init__.py:44: in include    'Specifying a namespace in django.conf.urls.include() without 'E   django.core.exceptions.ImproperlyConfigured: Specifying a namespace indjango.conf.urls.include() without providing an app_name is not supported.Set the app_name attribute in the included module, or pass a 2-tuple containingthe list of patterns and app_name instead.__________________ ERROR collecting tests/test_versioning.py ___________________tests/test_versioning.py:166: in <module>    class TestURLReversing(URLPatternsTestCase):tests/test_versioning.py:173: in TestURLReversing    url(r'^v1/', include(included, namespace='v1')),/django/conf/urls/__init__.py:44: in include    'Specifying a namespace in django.conf.urls.include() without 'E   django.core.exceptions.ImproperlyConfigured: Specifying a namespace indjango.conf.urls.include() without providing an app_name is not supported.Set the app_name attribute in the included module, or pass a 2-tuple containingthe list of patterns and app_name instead.

@felixxm
Copy link
ContributorAuthor

All remaining errors are related withdjango-guardian. They already fixed them (see276da317), we need to wait forv.1.4.7 version.

@lovelydinosaur
Copy link
Contributor

Great stuff!

@lovelydinosaurlovelydinosaur merged commit3001b56 intoencode:masterJan 30, 2017
@lovelydinosaurlovelydinosaur added this to the3.5.4 Release milestoneJan 30, 2017
@felixxmfelixxm deleted the issue-include-change branchJanuary 30, 2017 16:37
vpistis added a commit to vpistis/django-rest-framework that referenced this pull requestFeb 6, 2017
* master: (95 commits)  Add max_length and min_length arguments for ListField (encode#4877)  Update sponsors on README to include rollbar (encode#4876)  Added Rollbar to premium sponsors  fixed url checker ':' to 'http' (encode#4678)  Fixed `dedent` for tab indent.  Add test for pagination when limit not set  Fixed Django 2.0 compatibility due to `django.conf.urls.include` parameters change. (encode#4866)  Add remaining tests for generics (encode#4865)  Removed unnecessary importlib wrapper.  Updated Support section and added funding email (encode#4860)  Git add remaining tests for BaseSerializer (encode#4857)  Update machinalis links  Updated Machinalis links (encode#4856)  Add remaining tests for metadata (encode#4855)Fixedencode#4574 -- Removed multi-table inheritance auto created PK from serialize. (encode#4852)  Add couple of tests for filters (encode#4849)  Refactor according to comments in PR (encode#4848)  Add couple of tests for compat module (encode#4845)  Direct readers to info on how to add viewset docs (encode#4844)  Fixed test_one_to_one_with_inheritance. Added required on_delete attribute to OneToOneField field. (encode#4838)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

3.5.4 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@felixxm@lovelydinosaur@jpadilla

[8]ページ先頭

©2009-2025 Movatter.jp