Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
fixed url checker ':' to 'http'#4678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rest_framework/test.py Outdated
| defrequest(self,method,url,*args,**kwargs): | ||
| if':'notinurl: | ||
| if'http'notinurl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if not url.startswith('http') would be even better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ticosax Yes. It can be. So, should I update PR ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup
rest_framework/test.py Outdated
| defrequest(self,method,url,*args,**kwargs): | ||
| if':'notinurl: | ||
| if'http'notinurl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup
8a7bf4f to24b19c3Compare* master: (95 commits) Add max_length and min_length arguments for ListField (encode#4877) Update sponsors on README to include rollbar (encode#4876) Added Rollbar to premium sponsors fixed url checker ':' to 'http' (encode#4678) Fixed `dedent` for tab indent. Add test for pagination when limit not set Fixed Django 2.0 compatibility due to `django.conf.urls.include` parameters change. (encode#4866) Add remaining tests for generics (encode#4865) Removed unnecessary importlib wrapper. Updated Support section and added funding email (encode#4860) Git add remaining tests for BaseSerializer (encode#4857) Update machinalis links Updated Machinalis links (encode#4856) Add remaining tests for metadata (encode#4855)Fixedencode#4574 -- Removed multi-table inheritance auto created PK from serialize. (encode#4852) Add couple of tests for filters (encode#4849) Refactor according to comments in PR (encode#4848) Add couple of tests for compat module (encode#4845) Direct readers to info on how to add viewset docs (encode#4844) Fixed test_one_to_one_with_inheritance. Added required on_delete attribute to OneToOneField field. (encode#4838) ...
Description
RequestClient In this line it's checking with ':'. But think when url="example.com:2121" then this this check can't be OK. So if it checks only for
httporhttpsthen we can usehttpfor checking. :) That's all. 👍