Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Depth should reduce#2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Boomerangz
Copy link
Contributor

Depth should reduce

Depth should reduce
@jpadilla
Copy link
Contributor

@Boomerangz I think we need a bit more here to understand what's going on. What's the wrong current behavior and how does it compare with this. A test case might also be needed as well.

@Boomerangz
Copy link
ContributorAuthor

Ok. I'm sorry.
Some bug like this was fixed in issue
#2287
It was fixed in 2 lines of code. Depth was reducing on each level of nested serialization.
Now, in one of this lines depth isn't reducing.
My test case is totally similiar to the test case of the issue.
I set meta property depth=1, but when i check result i see full hierarchy of my models serialized

@jpadilla
Copy link
Contributor

@Boomerangz ah I see now. It seemed it was fixed in80bacc5 last year but was probably left out during the serializer rewrite.

@jpadilla
Copy link
Contributor

@tomchristie this looks good to me as is, wanted to check with you if it might have removed for a reason or by accident.

@lovelydinosaur
Copy link
Contributor

Yup - surprised we made it this far without it!

lovelydinosaur added a commit that referenced this pull requestApr 27, 2015
Depth should reduce on nested ModelSerializer classes.
@lovelydinosaurlovelydinosaur merged commit2eb9107 intoencode:masterApr 27, 2015
@lovelydinosaur
Copy link
Contributor

Thanks@Boomerangz!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

3.1.2 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@Boomerangz@jpadilla@lovelydinosaur

[8]ページ先頭

©2009-2025 Movatter.jp