Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Renamed validated_attrs to validated_data to be more in line with other code#2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mtschammer
Copy link
Contributor

Thecreateandupdate methods inBaseSerializerandListSerializer both takevalidated_dataas an argument. Those same methods onModelSerializer, however, takevalidated_attrs. This is confusing, especially considering thatvalidated_data is used in the documentation for the changelog.

@lovelydinosaur
Copy link
Contributor

Yup, good spot - should bevalidated_data throughout.
Your fix shouldn't be a breaking change, as anyone re-implementing these will have declared the signature themselves, so this looks good to me. Thanks!

lovelydinosaur added a commit that referenced this pull requestDec 3, 2014
…enameRenamed validated_attrs to validated_data to be more in line with other code
@lovelydinosaurlovelydinosaur merged commitf221b73 intoencode:masterDec 3, 2014
@lovelydinosaurlovelydinosaur added this to the3.0.1 Release milestoneDec 3, 2014
@mtschammer
Copy link
ContributorAuthor

Happy to help! :)

This was referencedDec 10, 2014
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

3.0.1 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@mtschammer@lovelydinosaur

[8]ページ先頭

©2009-2025 Movatter.jp