Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
OpenAPI: Ported docstring operation description from CoreAPI inspector.#6898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
OpenAPI: Ported docstring operation description from CoreAPI inspector.#6898
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carltongibson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@ysavary.
Really happy to see this done, but instead of duplicating the code from thecoreapi module, please can you bring it up into the baseViewInspector class.
Also, please could you go over the comments and code to make sure they make sense in a non-CoreAPI context? (For example, talk ofLinks is using CoreAPI terminology.)
Other than that, yes, super! 👍
# Conflicts:#tests/schemas/test_openapi.py
carltongibson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, this looks like a nice addition. Thank you.
I would like to document my operation with a description as a docstring comment like it was with coreapi.