Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Disable HTML inputs for dict/list fields#5702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carltongibson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Given current limitations, I agree that disabling these fields is the best approach.
Thesolution here is for users to provide their own templates adding whatever widgets are needed for their use-case. That's out of scope for core as of now. (Would make some good blog posts though.)
ListField&DictFielddo not seem to have proper HTML form support. Until they do, it would make sense to render a disabled form input, similar to how nested list serializers are currently handled.Is there any reason not to disable these inputs?
Additionally, I would add tests for this, but I don't see any relevant tests for serializer form rendering.