Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adding examples and documentation for caching#5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
carltongibson merged 1 commit intoencode:masterfrompratyushmittal:patch-1
Oct 20, 2017

Conversation

@pratyushmittal
Copy link
Contributor

@pratyushmittalpratyushmittal commentedOct 19, 2017•
edited by carltongibson
Loading

The default caching system of Django works very well with DRF. However, the usage is not very easy to understand for class based views as the documentation is spread across pages. This pull-request provides example code on how to use caching withapiviews andviewsets.

(Edit:@carltongibson:Closes#370)

carltongibson, edmorley, rpkilby, and pratyushmittal reacted with hooray emoji
The default caching system of Django works very well with DRF. However, the usage is not very easy to understand for class based views as the documentation is spread across pages. This pull-request provides example code on how to use caching with apiviews and viewsets.
Copy link
Collaborator

@carltongibsoncarltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this. I will give it a proper review tomorrow AM.

(I think there may be some long standing issues related to this... I need to have a look)

@carltongibsoncarltongibson added this to the3.7.2 milestoneOct 20, 2017
@carltongibson
Copy link
Collaborator

@pratyushmittal It turns out the issue was#370 — ourvery oldest open issue! So you get a big cheer for that: 🎉💃🏼🎇

This is a good beginning to a caching page. No doubt people will follow-up with more but this is what we need to get started.

Awesome! Thank you!

@carltongibsoncarltongibson merged commitf87699e intoencode:masterOct 20, 2017
@pratyushmittal
Copy link
ContributorAuthor

Thanks a lot@carltongibson for a super quick review, merge and appreciation :-)

carltongibson reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carltongibsoncarltongibsoncarltongibson left review comments

Assignees

No one assigned

Projects

None yet

Milestone

3.7.2 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@pratyushmittal@carltongibson
[8]ページ先頭
©2009-2025 Movatter.jp