Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix ModelSerializer custom named fields with source on model#5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jonsongoffwhite
Copy link
Contributor

@jonsongoffwhitejonsongoffwhite commentedSep 4, 2017•
edited by carltongibson
Loading

Description

Fixes#5389

Includes a test that fails on master, passes before#5138, and now passes with included fix.

@jonsongoffwhitejonsongoffwhite changed the titleFix/named sourceFix ModelSerializer custom named fields with source on modelSep 4, 2017
@carltongibson
Copy link
Collaborator

Hi@JHG14 Could I trouble you for a description please? Thanks!

Copy link
Collaborator

@carltongibsoncarltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep. Looks good. Thank you.

Copy link
Collaborator

@carltongibsoncarltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jonsongoffwhite
Copy link
ContributorAuthor

@carltongibson Should be good now!

carltongibson reacted with thumbs up emoji

@carltongibsoncarltongibson added this to the3.6.5 Release milestoneSep 4, 2017
@carltongibsoncarltongibson merged commit71ad99e intoencode:masterSep 4, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carltongibsoncarltongibsoncarltongibson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.0 Release

Development

Successfully merging this pull request may close these issues.

ModelSerializer custom named field source evaluates to True instead of field_name

2 participants

@jonsongoffwhite@carltongibson
[8]ページ先頭
©2009-2025 Movatter.jp