Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Closed
Labels
Milestone
Description
Checklist
- I have verified that that issue exists against the
masterbranch of Django REST framework. - I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
- This is not a usage question. (Those should be directed to thediscussion group instead.)
- This cannot be dealt with as a third party library. (We prefer new functionality to bein the form of third party libraries where possible.)
- I have reduced the issue to the simplest possible case.
- I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)
Steps to reproduce
- Create a View with a custom
ApiSettingswithEXCEPTION_HANDLERspecified - Trigger an exception and notice that the custom exception handler isn't triggered because the APIView class only ever uses
rest_framework.settings.api_settings.
Expected behavior
- View uses
self.settingssince views can override settings objects so easily.
Actual behavior
- Uses default handler instead
Extras
The 3.4 series usedself.settings.EXCEPTION_HANDLER but 3.5 moved to useget_exception_handler which started usingrest_framework.settings.api_settings.